@Observable Macro supports properties with the package access modifier
#71061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to add a test for this, but could not find where an existing it. I need your help... Thank you! |
|
as soon as the test is picked over I will close my commit in favor of this one. |
|
I cherry-picked your phausler@4e274ce at ea46fc2. Thank you so much. |
|
@swift-ci please test |
|
@swift-ci please test macOS |
|
@swift-ci please smoke test macOS |
treastrain
deleted the
observable-macro-supports-package-access-modifier
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to change the
@ObservableMacro so that properties with thepackageaccess modifier do not cause build errors.Resolves #71060.
(Thanks to @p-x9 via https://x.com/p_x9/status/1749374558732493102)