Skip to content

[Observation] Add support for package properties #72844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

phausler
Copy link
Contributor

@phausler phausler commented Apr 4, 2024

This modifies Observation macros to handle package properties.

Resolves:
rdar://114779977

@phausler phausler requested a review from a team as a code owner April 4, 2024 17:30
@phausler
Copy link
Contributor Author

phausler commented Apr 4, 2024

@swift-ci please test

@phausler
Copy link
Contributor Author

phausler commented Apr 4, 2024

@swift-ci please test

@treastrain
Copy link
Contributor

Would you review #71060 and #71061 that I have created in the past?

@phausler
Copy link
Contributor Author

phausler commented Apr 5, 2024

Yea, that issue is definitely the same thing.

@treastrain
Copy link
Contributor

OK. I'm prepared to cherry-pick your commit for the test at #71061 if needed.

@phausler
Copy link
Contributor Author

phausler commented Apr 5, 2024

sure, that sounds fine if you want the attribution on it. I just need to make sure it is tracked correctly.

@treastrain
Copy link
Contributor

Thank you very much. I have completed it. #71061 (comment)

@phausler phausler closed this Apr 8, 2024
@phausler
Copy link
Contributor Author

phausler commented Apr 8, 2024

closed in favor of #71061

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants