[CMake] Add option to perform SwiftParser validation by default #71173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
rintaro
commented
Jan 26, 2024
Comment on lines
+69
to
+73
| if(LLVM_ENABLE_ASSERTIONS) | ||
| target_compile_options(${name} PRIVATE "$<$<COMPILE_LANGUAGE:Swift>:SHELL:-Xcc -UNDEBUG>") | ||
| else() | ||
| target_compile_options(${name} PRIVATE "$<$<COMPILE_LANGUAGE:Swift>:SHELL:-Xcc -DNDEBUG>") | ||
| endif() |
There was a problem hiding this comment.
This is just a drive-by future proof fix. This ensures using the same NDEBUG between C/C++ and Swift.
|
@swift-ci Please smoke test macOS |
Disabled by default. We'll enable it for some build presets. rdar://121545713
swift-syntax PR testing. assertion-enabled source-compat-suite presets i.e. 'DA' and 'RA'
rintaro
force-pushed
the
cmake-parservalidatoin
branch
from
c47bedb to
a8db220
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test |
bnbarham
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled by default.
We'll enable it for some build presets.Enabled in
buildbot_swiftsyntax_{macos|linux}andsource_compat_suite_{macos|linux}_*Abuild presetsrdar://121545713