Skip to content

[6.0][CMake] Add option to perform SwiftParser validation by default #73016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 13, 2024
Merged

[6.0][CMake] Add option to perform SwiftParser validation by default #73016

merged 2 commits into from
Apr 13, 2024

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Apr 12, 2024 •
edited
Loading

Cherry-pick #71173 into release/6.0

  • Explanation: Previously, parser validation was enabled by default in "assertion" builds. Since it performs unnecessary parsing using SwiftSyntaxParser, it could causes performance issues. Add option to build-script that enables parser validation, and let's make it off by default.
  • Scope: CMake, Parsing
  • Risk: Low. build-sciript/CMake changes are trivial. Not-performing parser validation is well tested with no-assertion builds.
  • Testing: Passes existing test suite
  • Issues: rdar://121545713
  • Reviewer: @eeckstein @bnbarham

rintaro added 2 commits April 12, 2024 15:16
@rintaro
[CMake] Add option to perform SwiftParser validation by default
1e0c64c 
Disabled by default. We'll enable it for some build presets.

rdar://121545713
(cherry picked from commit 810a94c)
@rintaro
[build-preset] Enable SwiftParser validation in some presets
2f7a474 
swift-syntax PR testing.
assertion-enabled source-compat-suite presets i.e. 'DA' and 'RA'

(cherry picked from commit a8db220)
@rintaro rintaro requested a review from a team as a code owner April 12, 2024 22:18
@rintaro
Copy link
Member Author

rintaro commented Apr 12, 2024

@swift-ci Please test

@rintaro rintaro merged commit c83caf5 into swiftlang:release/6.0 Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @bnbarham