Skip to content

[stdlib] Define OS version numbers for SwiftStdlib 5.10 #71297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

lorentey
Copy link
Member

@lorentey lorentey commented Feb 1, 2024

macOS 14.4, iOS 17.4, watchOS 10.4, tvOS 17.4, and iPadOS 17.4 are currently in public beta testing, and they include the Swift 5.10 Standard Library.

Adjust the SwiftStdlib 5.10 macro to resolve to these version numbers rather than the placeholder 9999 versions.

5.10 does not ship with new Stdlib ABI entry points, so we aren't using this macro anywhere outside behavioral tests. The impact of this change ought to be correspondingly minimal.

(Ideally this needs to be cherry-picked to release/5.10 too, although if there isn't anything using it, it's not super critical.)

@lorentey
Copy link
Member Author

lorentey commented Feb 1, 2024

@swift-ci test

@lorentey
Copy link
Member Author

lorentey commented Feb 1, 2024

The two tests that mention SwiftStdlib 5.10 only use it to enable tests checking for new behavior, with no else branch where they would be expecting other results -- so if #available temporarily returning false on CI (which isn't running the beta OSes) isn't expected to cause any test failures.

@stephentyrone
Copy link
Contributor

Please go ahead and cherry-pick to release/5.10

@lorentey
Copy link
Member Author

lorentey commented Feb 1, 2024

I submitted #71304 for picking this to release/5.10.

@lorentey lorentey merged commit ee10a4e into swiftlang:main Feb 1, 2024
@lorentey lorentey deleted the define-5.10 branch February 1, 2024 22:38
al45tair added a commit to al45tair/swift that referenced this pull request Feb 2, 2024
This was just added to utils/availability-macros.def in swiftlang#71297.

rdar://120952971
al45tair added a commit to al45tair/swift that referenced this pull request Feb 2, 2024
This was just updated in swiftlang#71297.

rdar://121522431
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants