Skip to content

[5.10][stdlib] Define OS version numbers for SwiftStdlib 5.10 #71304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

lorentey
Copy link
Member

@lorentey lorentey commented Feb 1, 2024

(cherry picked from #71297)

Explanation: Routine prerelease task that publicly defines the OS versions that we expect will ship the Swift 5.10 Standard Library. These are used for availability declarations & conditions. (5.10 does not currently have any new declarations with SwiftStdlib 5.10, but there are two behavioral tests for the stdlib that are conditional on 5.10 availability.)
Scope: CMake & lit compiler invocations (textual change to an existing command-line argument), two test cases in the Stdlib test suite.
Issue: n.a.
Risk: Minimal. The SwiftStdlib 5.10 macro is only used in two tests; setting the versions will have the side effect of temporarily disabling those tests on ci.swift.org until executors get updated to matching OS versions.
Testing: Routine PR testing
Reviewer: @Azoy @tshortli @stephentyrone

(cherry picked from commit 9f66bd0)

# Conflicts:
#	utils/availability-macros.def
@lorentey lorentey requested a review from a team as a code owner February 1, 2024 04:00
@lorentey
Copy link
Member Author

lorentey commented Feb 1, 2024

@swift-ci test

@lorentey
Copy link
Member Author

lorentey commented Feb 1, 2024

Unrelated-looking failure on macOS.

[1400/1400] Testing WorkspaceTests.WorkspaceTests/testSkipUpdate
Test Suite 'Selected tests' started at 2024-02-01 07:08:29.245.Test Suite 'SwiftPMPackageTests.xctest' started at 2024-02-01 07:08:29.245.Test Suite 'BuildSystemDelegateTests' started at 2024-02-01 07:08:29.246.Test Case '-[BuildTests.BuildSystemDelegateTests testFilterNonFatalCodesignMessages]' started./Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-release/5.10/swiftpm/Sources/SPMTestSupport/misc.swift:144: error: -[BuildTests.BuildSystemDelegateTests testFilterNonFatalCodesignMessages] : failed: caught error: "terminated(1): /Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-release/5.10/build/buildbot_incremental/swiftpm-macosx-x86_64/x86_64-apple-macosx/release/swift-build --package-path /var/folders/bb/hcrjxg1s0b96pfst0ymhmp240000gn/T/Miscellaneous_TestableExe.qe0xtp/Miscellaneous_TestableExe --configuration debug output:
    error: 'miscellaneous_testableexe': Invalid manifest (compiled with: ["/Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-release/5.10/build/buildbot_incremental/toolchain-macosx-x86_64/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swiftc", "-vfsoverlay", "/var/folders/bb/hcrjxg1s0b96pfst0ymhmp240000gn/T/TemporaryDirectory.t0cGQc/vfs.yaml", "-L", "/Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-release/5.10/build/buildbot_incremental/swiftpm-macosx-x86_64/x86_64-apple-macosx/lib/swift/pm/ManifestAPI", "-lPackageDescription", "-Xlinker", "-rpath", "-Xlinker", "/Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-release/5.10/build/buildbot_incremental/swiftpm-macosx-x86_64/x86_64-apple-macosx/lib/swift/pm/ManifestAPI", "-target", "x86_64-apple-macosx13.0", "-sdk", "/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.2.sdk", "-F", "/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/Library/Frameworks", "-I", "/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/usr/lib", "-L", "/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/usr/lib", "-swift-version", "5", "-I", "/Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-release/5.10/build/buildbot_incremental/swiftpm-macosx-x86_64/x86_64-apple-macosx/lib/swift/pm/ManifestAPI", "-sdk", "/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.2.sdk", "-package-description-version", "5.5.0", "-module-cache-path", "/Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-release/5.10/build/buildbot_incremental/swiftpm-macosx-x86_64/x86_64-apple-macosx/release", "/private/var/folders/bb/hcrjxg1s0b96pfst0ymhmp240000gn/T/Miscellaneous_TestableExe.qe0xtp/Miscellaneous_TestableExe/Package.swift", "-Xfrontend", "-disable-implicit-concurrency-module-import", "-Xfrontend", "-disable-implicit-string-processing-module-import", "-o", "/var/folders/bb/hcrjxg1s0b96pfst0ymhmp240000gn/T/TemporaryDirectory.4K8hEy/miscellaneous_testableexe-manifest"])
    <unknown>:0: error: cannot open file '/private/var/folders/bb/hcrjxg1s0b96pfst0ymhmp240000gn/T/spm-tests-testInitPackageLibrary.fJYP3B/Foo/.build/x86_64-apple-macosx/debug/Foo.build/module.modulemap' (No such file or directory)
    /private/var/folders/bb/hcrjxg1s0b96pfst0ymhmp240000gn/T/Miscellaneous_TestableExe.qe0xtp/Miscellaneous_TestableExe/Package.swift:1:8: error: failed to build module 'Foundation'; this SDK is not supported by the compiler (the SDK is built with 'Apple Swift version 5.9.2 (swiftlang-5.9.2.2.11 clang-1500.1.0.2.2)', while this compiler is 'Apple Swift version 5.10-dev (LLVM 551823b7474ea05, Swift 4068000d48c5776)'). Please select a toolchain which matches the SDK.
    import Foundation
           ^
    "Test Case '-[BuildTests.BuildSystemDelegateTests testFilterNonFatalCodesignMessages]' failed (35.233 seconds).Test Suite 'BuildSystemDelegateTests' failed at 2024-02-01 07:09:04.479.
	 Executed 1 test, with 1 failure (1 unexpected) in 35.233 (35.233) secondsTest Suite 'SwiftPMPackageTests.xctest' failed at 2024-02-01 07:09:04.479.
	 Executed 1 test, with 1 failure (1 unexpected) in 35.233 (35.234) secondsTest Suite 'Selected tests' failed at 2024-02-01 07:09:04.479.
	 Executed 1 test, with 1 failure (1 unexpected) in 35.233 (35.235) seconds**** FAILURE EXECUTING SUBPROCESS ****
output: 
stderr: error: 'miscellaneous_testableexe': Invalid manifest (compiled with: ["/Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-release/5.10/build/buildbot_incremental/toolchain-macosx-x86_64/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swiftc", "-vfsoverlay", "/var/folders/bb/hcrjxg1s0b96pfst0ymhmp240000gn/T/TemporaryDirectory.t0cGQc/vfs.yaml", "-L", "/Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-release/5.10/build/buildbot_incremental/swiftpm-macosx-x86_64/x86_64-apple-macosx/lib/swift/pm/ManifestAPI", "-lPackageDescription", "-Xlinker", "-rpath", "-Xlinker", "/Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-release/5.10/build/buildbot_incremental/swiftpm-macosx-x86_64/x86_64-apple-macosx/lib/swift/pm/ManifestAPI", "-target", "x86_64-apple-macosx13.0", "-sdk", "/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.2.sdk", "-F", "/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/Library/Frameworks", "-I", "/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/usr/lib", "-L", "/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/usr/lib", "-swift-version", "5", "-I", "/Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-release/5.10/build/buildbot_incremental/swiftpm-macosx-x86_64/x86_64-apple-macosx/lib/swift/pm/ManifestAPI", "-sdk", "/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.2.sdk", "-package-description-version", "5.5.0", "-module-cache-path", "/Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-release/5.10/build/buildbot_incremental/swiftpm-macosx-x86_64/x86_64-apple-macosx/release", "/private/var/folders/bb/hcrjxg1s0b96pfst0ymhmp240000gn/T/Miscellaneous_TestableExe.qe0xtp/Miscellaneous_TestableExe/Package.swift", "-Xfrontend", "-disable-implicit-concurrency-module-import", "-Xfrontend", "-disable-implicit-string-processing-module-import", "-o", "/var/folders/bb/hcrjxg1s0b96pfst0ymhmp240000gn/T/TemporaryDirectory.4K8hEy/miscellaneous_testableexe-manifest"])
<unknown>:0: error: cannot open file '/private/var/folders/bb/hcrjxg1s0b96pfst0ymhmp240000gn/T/spm-tests-testInitPackageLibrary.fJYP3B/Foo/.build/x86_64-apple-macosx/debug/Foo.build/module.modulemap' (No such file or directory)
/private/var/folders/bb/hcrjxg1s0b96pfst0ymhmp240000gn/T/Miscellaneous_TestableExe.qe0xtp/Miscellaneous_TestableExe/Package.swift:1:8: error: failed to build module 'Foundation'; this SDK is not supported by the compiler (the SDK is built with 'Apple Swift version 5.9.2 (swiftlang-5.9.2.2.11 clang-1500.1.0.2.2)', while this compiler is 'Apple Swift version 5.10-dev (LLVM 551823b7474ea05, Swift 4068000d48c5776)'). Please select a toolchain which matches the SDK.
import Foundation
       ^

@lorentey
Copy link
Member Author

lorentey commented Feb 2, 2024

@swift-ci test

@stephentyrone stephentyrone merged commit ebaa8c6 into swiftlang:release/5.10 Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants