Non-copyable generics fixes, part 3 #71371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le() And consolidate the logic in ConformanceLookup.cpp.
…ONCOPYABLE_GENERICS
slavapestov
force-pushed
the
ncgenerics-fixes-3
branch
from
5e0e37a to
7e13fb1
Compare
…nostics Instead of stripping out requirements, let's pass the right PrintOptions.
slavapestov
force-pushed
the
ncgenerics-fixes-3
branch
from
bf62e0e to
84da6a6
Compare
The old logic looked at each generic parameter, and each conformance of that generic parameter. This missed conformance requirements where the subject type is a dependent member type. Also, the check for dependent witness tables was too strict, because it should have skipped protocols without witness tables. Refactor everything to instead walk the substitution map directly, and check each replacement type and conformance. This simplifies the logic and fixes failures with non-copyable generics enabled.
slavapestov
force-pushed
the
ncgenerics-fixes-3
branch
from
84da6a6 to
9f0bf00
Compare
slavapestov
requested review from
hborla,
xedin,
AnthonyLatsis,
ktoso,
zoecarver,
hyp,
egorzhdan and
tshortli
as code owners
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.