NCGenerics: more test fixes (v2) #71395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavon
requested review from
AnthonyLatsis,
hborla and
slavapestov
as code owners
|
@swift-ci smoke test |
kavon
changed the title
kavon
force-pushed
the
ncgenerics-test-fixes-kavon-v2
branch
from
465fa2a to
2901cca
Compare
slavapestov
reviewed
Feb 5, 2024
kavon
force-pushed
the
ncgenerics-test-fixes-kavon-v2
branch
from
49f5f1f to
4d8a8c9
Compare
|
@swift-ci smoke test |
kavon
force-pushed
the
ncgenerics-test-fixes-kavon-v2
branch
from
00d87f5 to
dc7aef7
Compare
kavon
requested review from
ktoso,
zoecarver,
hyp and
egorzhdan
as code owners
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
preset=ncgenerics,smoketest=macosx |
We let TypeCheckAttr diagnose illega uses of the attribute. In addition, we need to exclude protocols from inferring a marking, because when we build the StructuralRequirements for a protocol, we ignore the "marking" this we'll miss this legacy attribute. fixes Sema/moveonly_decl_attr.swift
The interface files were still printing inverses on the invertible protocols, when that's not required. Doing so yielded warnings during the build because `~Escapable` isn't yet ready for appearing in the stdlib.
An unbound generic type is not something that should end up in `isNoncopyable` or `isEscapable` queries because there are no conformances for such a type; it's unbound! fixes test/Constraints/closures.swift
kavon
force-pushed
the
ncgenerics-test-fixes-kavon-v2
branch
from
fc2f3af to
ee12fd6
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
base branch is #71371