[Distributed] Re-implement ad-hoc requirements into dynamic witness table lookup for SerializationRequirement conformance
#71435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is still a draft because we need to adjust distributed thunk synthesis to not assume that |
ktoso
reviewed
Feb 7, 2024
ktoso
reviewed
Feb 9, 2024
…computeSubstitutions` This is going to be used to determine whether the substitutions are computed for `DistributedActorSystem::remoteCall` and adjust the generic signature with witness conformance requirements.
…f `DistributedActorSystem.remoteCall` Conformance requirement between on `Res` and `SerializationRequirement` of `DistributedActorSystem.remoteCall` are not expressible at the moment but they are verified by Sema so it's okay to omit them here and lookup dynamically during IRGen.
…tributedActorSystem.remoteCall` witness
…tedActorSystem.remoteCall` witnesses When IRGen is building a protocol witness thunk for a `DistributedActorSystem.remoteCall` requirement we need to supply witness tables associated with `Res` generic parameter which are not expressible on the requirement because they come from `SerializationRequirement` associated type.
…equirements Instead of handing failures in `matchWitness` let's syntehsize conformances during solving. Next step would be to record them and use in `Solution::computeSubstitutions`.
…uted requirements
…InvocationEncoder.record{Argument, ReturnType}`
…InvocationDecoder.decodeNextArgument`
…InvocationResultHandler.onReturn`
…thesis This is no longer necessary because `onReturn` is a protocol requirement now.
…nesses with ad-hoc serialization requirement
… to new requirements
…d type for encoder/decoder/result
…es for `actorSystem` references Things like `makeInvocationEncoder()` and all of the `record*` methods can now be called through witnesses.
…ss thunk `decodeNextArgument` is now a requirement, so thunks should be always calling that instead of trying to dispatch directly.
…ILFunction
Ad-hoc requirements are now obsolete by making `remoteCall`,
`record{Argument, ReturnType}`, `decodeNextArgument` protocols
requirements and injecting witness tables for `SerializationRequirement`
conformances during IRGen.
…n is in type context
xedin
force-pushed
the
fix-need-for-adhoc-distributed-requirements
branch
from
4e40cc4 to
0cc26cf
Compare
xedin
requested review from
AnthonyLatsis,
hborla and
slavapestov
as code owners
|
@swift-ci please test |
ktoso
approved these changes
Feb 12, 2024
| /// 'decodeNextArgument' which must be retained, as it is only used from IRGen | ||
| /// and such, appears as-if unused in SIL and would get optimized away. | ||
| // TODO: Consider making this a general "references adhoc functions" and make it an array? | ||
| SILFunction *RefAdHocRequirementFunction = nullptr; |
| void EmitPolymorphicParameters::injectAdHocDistributedRequirements() { | ||
| // FIXME: We need a better way to recognize that function is | ||
| // a thunk for witness of `remoteCall` requirement. | ||
| if (!Fn.hasLocation()) |
There was a problem hiding this comment.
Ah no this is a SILFunction I guess, so the below doesn't really help.
--
In my other PR I was actually going to add:
/// Record which function this is a thunk for, we'll need this to link back
/// calls in case this is a distributed requirement witness.
thunk->getAttrs().add(
new (C) DistributedThunkTargetAttr(func));
so we could check for it to detect a thunk;
https://github.com/apple/swift/pull/70928/files#diff-c5ee3c123c92773a4f07b456c2c0051c7a9dfdc81c5c0234ba5da6389bd82a07R793
I'll cleanup that PR shortly
There was a problem hiding this comment.
Great! Once that's there we can use it both here and in FunctionSignatureOpts optimizer pass.
xedin
changed the title
Res of DistributedActorSystem.remoteCallSerializationRequirement conformance
|
@swift-ci please test |
|
@swift-ci please build toolchain macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SerializationRequirementofDistributedActorSystembecame a primary associated typeremoteCallandremoteCallVoidofDistributedActorSystemare now requirementsResgeneric parameter of eachremoteCallwitnessRes: SerializationRequirementthat is requiredfor every witness (but cannot be expressed on the requirement) of
DistributedActorSystem.remoteCalldynamically in a protocol witness thunk.