[DNM][Distributed] Handle generic actors and Codable better #71467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…computeSubstitutions` This is going to be used to determine whether the substitutions are computed for `DistributedActorSystem::remoteCall` and adjust the generic signature with witness conformance requirements.
…irement of distributed actor system
…f `DistributedActorSystem.remoteCall` Conformance requirement between on `Res` and `SerializationRequirement` of `DistributedActorSystem.remoteCall` are not expressible at the moment but they are verified by Sema so it's okay to omit them here and lookup dynamically during IRGen.
…tributedActorSystem.remoteCall` witness
…tedActorSystem.remoteCall` witnesses When IRGen is building a protocol witness thunk for a `DistributedActorSystem.remoteCall` requirement we need to supply witness tables associated with `Res` generic parameter which are not expressible on the requirement because they come from `SerializationRequirement` associated type.
ktoso
requested review from
AnthonyLatsis,
hborla,
slavapestov and
xedin
as code owners
ktoso
commented
Feb 8, 2024
|
@swift-ci please smoke test |
slavapestov
reviewed
Feb 14, 2024
| @@ -763,6 +762,30 @@ addDistributedActorCodableConformance( | |||
| return nullptr; | |||
| } | |||
|
|
|||
| if (actor->isGeneric()) { | |||
There was a problem hiding this comment.
Do you want isGeneric() or isGenericContext()?
slavapestov
reviewed
Feb 14, 2024
|
|
||
| assert(proto->isSpecificProtocol(swift::KnownProtocolKind::Decodable) || | ||
| proto->isSpecificProtocol(swift::KnownProtocolKind::Encodable)); | ||
|
|
||
| // === Does the actor explicitly conform to the protocol already? | ||
| auto explicitConformance = | ||
| module->lookupConformance(actor->getInterfaceType(), proto); |
There was a problem hiding this comment.
This will always return false because getInterfaceType() returns a metatype given a TypeDecl
|
Thanks Slava, I'll be looking into this one deeper next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #71435
And adds the last commit which cleans up our "implicit codable" logic.
I think this is probably good enough tbh -- see test cases @xedin
The commit: 5f669bb