Skip to content

[swift-3.1-branch] Fix + and - operations on DispatchTime and DispatchWallTime #7158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2017
Merged

[swift-3.1-branch] Fix + and - operations on DispatchTime and DispatchWallTime #7158

merged 1 commit into from
Jan 31, 2017

Conversation

moiseev
Copy link
Contributor

@moiseev moiseev commented Jan 31, 2017

  • Explanation: Fixing an incorrect behavior for non-finite values of Double paramter
  • Scope of Issue: Enables more safe ways to use the Dispatch overlay
  • Origination: The original code contained this bug
  • Risk: minimal
  • Reviewed By: Kim Topley (@ktopley-apple )
  • Testing: Existing test suite + an extra test
  • Directions for QA: N/A

rdar://problem/30276292

@moiseev
[dispatch] Fix + and - operations on DispatchTime and DispatchWallTime (
4a37368 
swiftlang#6961)

... for the cases where `seconds` parameter is NaN or infinite.
Fixes <rdar://problem/29764171>
CCC: <rdar://problem/30276292>
@moiseev
Copy link
Contributor Author

moiseev commented Jan 31, 2017

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 4a37368
Test requested by - @moiseev

@moiseev
Copy link
Contributor Author

moiseev commented Jan 31, 2017

Git connection failure.
@swift-ci Please test Linux platform

@tkremenek tkremenek merged commit 2b2d36d into swiftlang:swift-3.1-branch Jan 31, 2017
@moiseev moiseev deleted the infinite-double-dispatch branch January 31, 2017 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tkremenek tkremenek

@ematejska ematejska

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moiseev @swift-ci @tkremenek @ematejska