[stdlib] convert withUnsafeBytes() to typed throws
#72074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
glessard
changed the title
withUnsafeBytes() to typed throws
glessard
force-pushed
the
toplevel-withbytes-typed-throws
branch
2 times, most recently
from
f6c0f4f to
b2f28d0
Compare
|
@swift-ci please test |
glessard
force-pushed
the
toplevel-withbytes-typed-throws
branch
from
b2f28d0 to
b99900f
Compare
glessard
force-pushed
the
toplevel-withbytes-typed-throws
branch
from
b99900f to
e02d8ab
Compare
|
@swift-ci please test |
glessard
commented
Mar 5, 2024
Update test/api-digester/stability-stdlib-abi-without-asserts.test
|
@swift-ci please test |
|
@swift-ci please test linux platform |
|
@swift-ci please test windows platform |
Azoy
reviewed
Mar 6, 2024
| _ body: (UnsafeMutableRawBufferPointer) throws(E) -> Result | ||
| ) throws(E) -> Result { | ||
| let pointer = UnsafeMutableRawPointer(Builtin.addressof(&value)) | ||
| return try body(.init(start: pointer, count: MemoryLayout<T>.size)) |
There was a problem hiding this comment.
Any particular reason for writing this way instead of how the old thing was doing it? Not opposed, just curious 🙂
There was a problem hiding this comment.
The old way crashed the compiler; going straight to the builtin is a workaround. (Not entirely successful, it seems.)
|
The previous failure is likely fixed by #72152 |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the ongoing conversion of standard library rethrows functions, after SE-0413.
This converts the top-level
withUnsafe[Mutable]Bytes(of:_:)functions, and their corresponding no-stack-protection equivalents. There was no_withUnprotectedUnsafeMutableBytes()previously — added here.