Skip to content

Fix computation of argument index in the presence of indirect error results #72152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

meg-gupta
Copy link
Contributor

@meg-gupta meg-gupta commented Mar 7, 2024

Fixes rdar://124108894

With typed throws, we can have indirect error results, this changes how we compute argument index. Update 2 incorrect instances exposed by rdar://124108894.

@meg-gupta meg-gupta requested a review from aschwaighofer March 7, 2024 10:04
@meg-gupta
Copy link
Contributor Author

meg-gupta commented Mar 7, 2024

There are other instances where only getNumIndirectSILResults() seem to be used, I have not looked at any of them. Fixing just 2 incorrect instances exposed by the bug.

@meg-gupta
Copy link
Contributor Author

@swift-ci test

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@meg-gupta
Copy link
Contributor Author

@swift-ci smoke test

@meg-gupta meg-gupta enabled auto-merge March 7, 2024 18:42
@meg-gupta
Copy link
Contributor Author

@swift-ci smoke test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants