[Sema/ClangImporter] Improvements to witness matching #72277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
requested review from
ahoppen,
bnbarham,
hamishknight,
rintaro,
ktoso,
AnthonyLatsis,
hborla,
slavapestov,
zoecarver,
hyp and
egorzhdan
as code owners
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please test source compatibility release |
…t declaration Locators used to support only expressions which is no longer the case.
…with ObjC requirements Since importer ignored `swift_attr` that appeared in a type context until recently we need to maintain status quo with concurrency stripping from ObjC requirements in modes that don't have full concurrency checking enabled.
… down to a class `any C` where `C` is a class is not a well-formed type.
xedin
force-pushed
the
improvements-to-protocol-witness-matching
branch
from
edf4065 to
5890de3
Compare
|
@swift-ci please test |
hborla
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Should we replace the ObjC checks with a check for preconcurrency requirements? I think we want the same behavior for Swift requirements that are marked @preconcurrency, and ObjC isn't special other than all imported declarations are treated as @preconcurrency.
|
I want to investigate expanding this separately, main goal was to remove the workaround for ObjC requirements that got concurrency stripped always and thus had no path for witnesses to be updated... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix locators for requirement-witness matching (modern locators can be anchored on declarations)
Warn about sendability mismatches associated with ObjC requirements
Instead of stripping concurrency, handle stripping gracefully during
repairFailuresand reflect that in the solution score.This way we can maintain source compatibility and allow adding concurrency annotations.
ClangImporter: Wrap compositions with Sendable protocol into existentials
Resolves: #65730