[6.0][Sema/ClangImporter] Improvements to witness matching #72679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t declaration Locators used to support only expressions which is no longer the case. (cherry picked from commit 31e385f)
(cherry picked from commit 4d501ef)
(cherry picked from commit 38a6d88)
… witness locator (cherry picked from commit 0f26da4)
…with ObjC requirements Since importer ignored `swift_attr` that appeared in a type context until recently we need to maintain status quo with concurrency stripping from ObjC requirements in modes that don't have full concurrency checking enabled. (cherry picked from commit c06a1a8)
… down to a class `any C` where `C` is a class is not a well-formed type. (cherry picked from commit 10541ef)
…tials Resolves: swiftlang#65730 (cherry picked from commit a90e591)
(cherry picked from commit 5890de3)
|
@swift-ci please test |
hborla
approved these changes
Mar 28, 2024
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #72277
Improves handling of requirement-to-witness matching for ObjC members by stripping concurrency annotations only when absolutely necessary.
Scope: Witness matching.
Main Branch PRs: [Sema/ClangImporter] Improvements to witness matching #72277
Risk: Low
Reviewed By: @hborla
Testing: Added test-cases to the test suite.