[6.0] Allow @isolated(any) mismatches in witness matching. #72672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not really convinced that this shouldn't be done by introducing a new kind of constraint rather than hacking in what are essentially conversions as "bind" constraints, but this is the most direct path for now. Fixes rdar://125394096
|
@swift-ci Please test |
hborla
approved these changes
Mar 28, 2024
|
Blocked on #72679. |
|
@swift-ci please test |
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not really convinced that this shouldn't be done by introducing a new kind of constraint rather than hacking in what are essentially conversions as "bind" constraints, but this is the most direct path for now
Explanation: Witness matching was not allowing a function that took an
@isolated(any)parameter to witness a requirement that took a non-@isolated(any)parameter. This caused a source break with a project that added a protocol for differentTaskGrouptypes.Scope: Fixes a source compatibility issue. Should have no impact outside of witness matching or if
@isolated(any)isn't involved.Issue: rdar://125394096
Original PR: #72641
Risk: Low
Testing: Just regression testing
Reviewer: @xedin approved the original PR