Allow @isolated(any) mismatches in witness matching. #72641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
xedin
reviewed
Mar 28, 2024
I'm not really convinced that this shouldn't be done by introducing a new kind of constraint rather than hacking in what are essentially conversions as "bind" constraints, but this is the most direct path for now. Fixes rdar://125394096
rjmccall
force-pushed
the
isolated-any-witness-mismatch
branch
from
8c2c1a0 to
b773c49
Compare
|
@swift-ci Please test |
xedin
approved these changes
Mar 28, 2024
| @@ -3041,6 +3041,13 @@ matchFunctionThrowing(ConstraintSystem &cs, | |||
| } | |||
| } | |||
|
|
|||
| static bool isWitnessMatching(ConstraintLocatorBuilder locator) { | |||
There was a problem hiding this comment.
Nit: would be great to make it a method on ConstraintLocatorBuilder because it could be made more efficient there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://125394096