[SILVerifier] Add detection of conflicting debug variables #72397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test source compatibility |
Snowy1803
force-pushed
the
verifier-conflicting-debug-value-types
branch
2 times, most recently
from
83f7f1c to
0ad5044
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
looks like |
For address-only types, a temporary was emitted with the same debug variable and same scope as the instruction it is moved to after entering a shared case, but it would have a different type, which would create a conflict. The better way to fix this would probably to use a different scope for both, but the variable is moved immediately anyway.
Snowy1803
force-pushed
the
verifier-conflicting-debug-value-types
branch
from
0ad5044 to
0162ccd
Compare
Snowy1803
force-pushed
the
verifier-conflicting-debug-value-types
branch
from
0162ccd to
fed03cc
Compare
|
@swift-ci please smoke test |
|
@swift-ci test source compatibility |
|
@swift-ci test linux |
adrian-prantl
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IRGenDebugInfo assumes, using a cache, that all variables with the same scope, same name and same source location, are lowered to the same type. This assumption was broken in some rare cases. This PR fixes those cases and adds a SILVerifier assertion to detect them early.
rdar://124555787