[6.0] [SILVerifier] Add detection of conflicting debug variables #72576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Snowy1803
commented
Mar 26, 2024
Snowy1803
commented
- Explanation: Some debug information was generated incorrectly (nested tuples in prolog, conflict in switch statement, no specialization of debug variable type). This PR fixes those issues and adds a verifier check to ensure the assumptions of IRGenDebugInfo aren't broken.
- Scope: Fixes debug value instructions in SIL
- Original PR: [SILVerifier] Add detection of conflicting debug variables #72397
- Risk: The SILVerifier check could catch some issues we haven't detected yet, but it would be helpful to know about those issues as soon as possible
- Testing: The SILVerifier check ensures all debug info is correct. The Source Compatibility Suite is passing
- Issue: rdar://124555787
- Reviewer: @adrian-prantl
…prolog (cherry picked from commit 0cff76e)
(cherry picked from commit 3c1ef77)
(cherry picked from commit ca8c6d4)
For address-only types, a temporary was emitted with the same debug variable and same scope as the instruction it is moved to after entering a shared case, but it would have a different type, which would create a conflict. The better way to fix this would probably to use a different scope for both, but the variable is moved immediately anyway. (cherry picked from commit 04ab380)
(cherry picked from commit fed03cc)
|
@swift-ci test |
|
@swift-ci please test windows platform |
adrian-prantl
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.