AsyncIteratorProtocol conformance fixes #72673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
requested review from
ktoso,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
DougGregor
changed the title
When inferring the `Failure` associated type from the `next()` witness, account for the fact that it might itself use typed throws. Use the specified thrown error type for the inferred witness of `Failure`. Fixes rdar://125446918.
New async iterators should be able to implement only `next(isolation:)` and get the older `next()` implementation via a default. Implement the appropriate default witness. Fixes rdar://125447861.
DougGregor
force-pushed
the
async-sequence-fixes
branch
from
f414dda to
220392b
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two issues that make
AsyncSequenceandAsyncIteratorProtocolconformances harder than necessary:next()that uses typed throws, infer theFailuretype from the thrown error type ofnext(). (rdar://125446918)next()in terms ofnext(isolation:), so conforming types can implement only the latter. (rdar://125447861)