[6.0] AsyncIteratorProtocol conformance fixes #72675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When inferring the `Failure` associated type from the `next()` witness, account for the fact that it might itself use typed throws. Use the specified thrown error type for the inferred witness of `Failure`. Fixes rdar://125446918.
New async iterators should be able to implement only `next(isolation:)` and get the older `next()` implementation via a default. Implement the appropriate default witness. Fixes rdar://125447861.
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test Windows |
hborla
approved these changes
Mar 29, 2024
|
@swift-ci please test macOS |
|
@swift-ci please test |
This was referenced Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Address two issues that make conformance to
AsyncIteratorProtocolharder to conform to than they need to be. First, correctly infer the thrown error type fromnext()if it adopts typed throws butnext(isolation:)is defaulted. Second, defaultnext()in terms ofnext(isolation:)so one need only implement one of them.Issue: rdar://125446918 & rdar://125447861
Original PR: #72673
Risk: Low. The change only impacts associated type inference in a narrow case for new code (where
next()has adopted type throws) and makes conformance toAsyncIteratorProtocolsimpler.Testing: New tests.