[6.0] Revert immutable let changes 6.0 #74056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test macOS |
This reverts commit de0288a.
|
@swift-ci please test |
tbkka
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Revert a series of changes that improved on the modeling of immutability for
letproperties in initializers within the type checker, because it has caused various regressions and needs work. The root problem that triggered this work is theAsyncIteratorProtocol.next()default implementation in terms ofnext(isolation:), so remove that as well.Reverted PRs: #73664, #73910, #72675 (partial)
Radar/issue: rdar://128890586, rdar://129031705, rdar://129065482
Risk: Low. Reverting to a known-good state.