🌸[6.0][Concurrency] Remove _unsafeInheritExecutor from public APIs, use #isolation #72830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
ktoso
added
concurrency
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
ktoso
changed the title
Otherwise we get warnings when task groups are used within an actor. Add global actor tests to cover the specific situation. resolves rdar://122846553 futher ABI safeguarding
rdar://125307764 abi cleanup
ktoso
force-pushed
the
pick-waitForAll-isolation
branch
from
5aec7cb to
3d372d3
Compare
hborla
approved these changes
Apr 5, 2024
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: In order to avoid isolation boundary warnings when task groups are used inside (global) actors we need to inherit isolation contest to most of their async APIs. Specifically, this PR resolves next() and waitForAll() now inheriting caller isolation.
Without this fix, the added test case would have failed with:
Risk: Low, because all existing ABI entrypoints are retained.
Review by: @hborla
Testing: CI testing
Original PR: #72794 #72578 #72862
Radar: rdar://122846553Otherwise we get warnings when task groups are used within an actor.
Add global actor tests to cover the specific situation.
resolves rdar://122846553