[Distributed] Diagnose missing import also for funcs in extensions #72923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
force-pushed
the
wip-diagnose-missing-import
branch
from
1bc2f93 to
09d41bb
Compare
xedin
approved these changes
Apr 9, 2024
Resolves rdar://125813581
ktoso
force-pushed
the
wip-diagnose-missing-import
branch
from
09d41bb to
7cd9063
Compare
|
@swift-ci please smoke test |
slavapestov
reviewed
Apr 9, 2024
| @@ -231,6 +231,7 @@ deriveBodyDistributed_thunk(AbstractFunctionDecl *thunk, void *context) { | |||
|
|
|||
| // === Type: | |||
| StructDecl *RCT = C.getRemoteCallTargetDecl(); | |||
| assert(RCT && "Missing RemoteCalLTarget declaration"); | |||
There was a problem hiding this comment.
whoops, thanks I'll fix :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: When a distributed func was declared in an extension in a file that did not import the Distributed module, though the extension was made properly on a distributed actor, we would crash in synthesis in SILGen because synthesis refers to types in the distributed module and the import is necessary.
This patch properly diagnoses missing imports whenever a distributed func is used somewhere.
Risk: Low, only improved diagnostics rather than crashing the compiler for distributed func declarations.
Radar: rdar://125813581