[Distributed] Offer fixit for import Distributed when it is required #72948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
xedin
reviewed
Apr 10, 2024
| // @_spi imports. | ||
| if (Member->isSPI()) { | ||
| auto spiGroups = Member->getSPIGroups(); | ||
| if (!spiGroups.empty()) { |
There was a problem hiding this comment.
I think somebody more familiar with SPI should take a look at this because it seems like we should mention more than just the first one maybe? /cc @xymus
There was a problem hiding this comment.
I took this from what it was doing in another place that @DougGregor developed for such imports so it's probably ok enough but definitely welcome some more input!
ktoso
force-pushed
the
wip-better-import-distributed-fixit
branch
from
2aac251 to
66a1be1
Compare
|
@swift-ci please smoke test |
ktoso
force-pushed
the
wip-better-import-distributed-fixit
branch
from
66a1be1 to
8515374
Compare
|
Sigh, import Foundation broke linux test ofc. Fixed by changing to import Swift |
|
@swift-ci please smoke test |
|
|
|
@swift-ci please smoke test Linux |
|
@swift-ci please smoke test macOS |
|
@swift-ci please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generalizes some "find best place for import fixit" code and applies it to suggesting
Distributedmodule imports.Also, rewording the error a little bit as review follow up.