[Debuginfo] Small fixes #73009
Merged
[Debuginfo] Small fixes #73009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
The source location for the variable should be the value in VarInfo if set, otherwise it should use the location of the instruction. Both ways should be consistent, and as we use column number if VarInfo is set, we have to do it if isnt, too.
SILBuilderWithScope ignores the scope of the debug value and uses the scope of the next real instruction. We want to preserve the scope of the original debug value, so we pass it explicitly.
Snowy1803
force-pushed
the
debuginfo-small-fixes
branch
2 times, most recently
from
7623a5d to
06d39a2
Compare
Salvage Debug Info was only being called for simplifications, and not for function passes written in Swift. Salvage Debug Info is now called for both cases.
Snowy1803
force-pushed
the
debuginfo-small-fixes
branch
from
06d39a2 to
4a543c8
Compare
|
@swift-ci please smoke test |
| bb0: | ||
| %0 = alloc_stack $Int, var, name "a" | ||
| %1 = integer_literal $Builtin.Int64, 1 | ||
| %2 = struct $Int (%1 : $Builtin.Int64) |
There was a problem hiding this comment.
This test will probably not work on 32-bit platforms. Could you rewrite it to hardcode an Int32?
| // CHECK: @llvm.dbg.declare(metadata ptr | ||
| // CHECK-SAME: metadata ![[VAR_DI:[0-9]+]] | ||
| // CHECK-SAME: ), !dbg ![[LOC_DI:[0-9]+]] | ||
| debug_value %0 : $Builtin.Int64, var, name "x", loc "simple.swift":1:16, scope 2 |
adrian-prantl
approved these changes
Apr 16, 2024
|
@swift-ci test |
|
Well, test/SILOptimizer/dead_store_elim.sil seems to pass the bots and does this, so this isn't any worse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes multiple small fixes, necessary for a bigger change.
With those changes, there are 0.06% less variables lost at the SIL level. It does not change the number of variables in the final binary.