[6.0] [DebugInfo] Small fixes #73114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Snowy1803
commented
Apr 18, 2024
Snowy1803
commented
- Explanation: This PR fixes small debug-info related issues. See the commits for more information.
- Scope: Adds debug values in swift passes, fix emitted debug info.
- Original PR: [Debuginfo] Small fixes #73009 (+ [DebugInfo] Fix dead-store-elim test for 32 bits #73084)
- Risk: Low, only changes to debug values
- Testing: New tests have been added
- Issue: None
- Reviewer: @adrian-prantl
The source location for the variable should be the value in VarInfo if set, otherwise it should use the location of the instruction. Both ways should be consistent, and as we use column number if VarInfo is set, we have to do it if isnt, too. (cherry picked from commit 3136d2e)
(cherry picked from commit 96cf233)
(cherry picked from commit 5512df5)
SILBuilderWithScope ignores the scope of the debug value and uses the scope of the next real instruction. We want to preserve the scope of the original debug value, so we pass it explicitly. (cherry picked from commit fac61c5)
Salvage Debug Info was only being called for simplifications, and not for function passes written in Swift. Salvage Debug Info is now called for both cases. (cherry picked from commit 4a543c8)
rdar://126620071 (cherry picked from commit a9d89e5)
|
@swift-ci please test |
adrian-prantl
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.