[Distributed][Macro] Improve diagnostics, handle edge cases, properties, assoc types #73046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
ktoso
force-pushed
the
wip-distributed-macro-diagnostics-improvements
branch
from
3edfcc6 to
02d612d
Compare
|
@swift-ci please smoke test |
ktoso
force-pushed
the
wip-distributed-macro-diagnostics-improvements
branch
from
02d612d to
53424a6
Compare
|
@swift-ci please smoke test |
ktoso
force-pushed
the
wip-distributed-macro-diagnostics-improvements
branch
from
53424a6 to
115f2b3
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The new distributed protocol macro creates stubs from protocols. We need to handle some more complex protocol requirements, such as properties with effects etc.
Scope/Impact: Low, just impacts adopters of the distributed protocol macro.
Risk: Low, just cleanups in edge cases of the _DistributedProtocol macro
Testing: CI testing
Radar: rdar://126311284