[6.0][Distributed][Macro] Handle more edge cases with distributed protocol macro #73047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
requested review from
a team,
hborla,
slavapestov,
xedin,
shahmishal,
ahoppen,
bnbarham,
hamishknight,
rintaro,
adrian-prantl,
AnthonyLatsis,
QuietMisdreavus,
kavon,
artemcm,
CodaFi,
DougGregor,
zoecarver,
hyp,
egorzhdan,
mikeash,
al45tair,
tshortli and
eeckstein
as code owners
ktoso
removed request for
CodaFi,
adrian-prantl,
shahmishal,
al45tair,
egorzhdan,
ahoppen,
QuietMisdreavus,
artemcm,
zoecarver,
hamishknight,
eeckstein,
tshortli and
AnthonyLatsis
|
Whoops, sorry for the mass ping -- wrong branch initially, fixed. |
ktoso
changed the title
|
@swift-ci please test |
ktoso
added
distributed
ahoppen
reviewed
Apr 16, 2024
|
Thanks @ahoppen seems I picked too much here |
ktoso
force-pushed
the
pick-wip-distributed-macro-diagnostics-improvements
branch
from
dda1b8d to
450256c
Compare
ktoso
force-pushed
the
pick-wip-distributed-macro-diagnostics-improvements
branch
from
450256c to
79cae1c
Compare
|
@swift-ci please test |
ktoso
changed the title
|
@swift-ci please test macOS CI was borked last evening meh |
hborla
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The new distributed protocol macro creates stubs from protocols. We need to handle some more complex protocol requirements, such as properties with effects etc.
Scope/Impact: Low, just impacts adopters of the distributed protocol macro.
Risk: Low, just cleanups in edge cases of the _DistributedProtocol macro
Testing: CI testing
Reviewed by: @xedin
Original PR: #73046
Radar: Radar: rdar://126311284