Respect the module ABI name when mangling for the debugger #73090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mangled name produced for the debugger should match the one emitted in reflection metadata, otherwise LLDB will not be able to lookup types when the module is compiled with the -module-abi-name flag. rdar://125848324
augusto2112
requested review from
adrian-prantl,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci smoke test |
adrian-prantl
approved these changes
Apr 17, 2024
| // reconstruct AST types from mangled names when using that attribute. | ||
| if ((RespectOriginallyDefinedIn || | ||
| (module->getName().str() != SWIFT_CONCURRENCY_NAME && | ||
| !module->getABIName().str().starts_with( |
There was a problem hiding this comment.
There's a CMake variable:
# Add unique ABI prefix to swift-syntax libraries so that compiler libraries (e.g. sourcekitdInProc)
# can be used from tools that has its own swift-syntax libraries as SwiftPM dependencies.
set(SWIFT_MODULE_ABI_NAME_PREFIX "Compiler")
This is prefixed to swift-syntax. It could potentially be prefixed to some other special compiler library in the future, so I'm checking for that. Option 2 would be to specifically check for "CompilerSwiftSyntax"
|
@swift-ci macOS |
|
@swift-ci test macos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mangled name produced for the debugger should match the one emitted in reflection metadata, otherwise LLDB will not be able to lookup types when the module is compiled with the -module-abi-name flag.
rdar://125848324