[NoncopyablePartialConsumption] Promote to feature. #73121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nate-chandler
requested review from
hborla,
slavapestov,
xedin and
kavon
as code owners
nate-chandler
requested review from
jckarter
and removed request for
xedin,
slavapestov and
hborla
jckarter
approved these changes
Apr 18, 2024
Remove all checks for the feature flag. It's on all the time.
A destroy_value of an on-stack partial apply isn't actually a consuming use, so don't treat it as one.
Previously, the enum representation was fixed to represent the different cases payloads separately with the unchecked_take_enum_data_addr instruction consuming all fields but that whose address is obtained. In a few places, handling for enum deinits was left undone with an assertion that the enum not have one. Here, the deinit bit of the enum is shifted to the end. And the assertions are replaced with handling. Finally, the logic for inserting destroys after switch_enum_addr instructions is fixed.
nate-chandler
force-pushed
the
rdar126715654
branch
from
dd1a86b to
d11d97d
Compare
nate-chandler
requested review from
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight and
rintaro
as code owners
nate-chandler
removed request for
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight and
rintaro
It's not allowed to replace ued(enum(x)) with x if the enum in question has a deinit.
It relies on complete lifetimes for its analysis. So if there are any instructions to check, complete all lifetimes in the function first.
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please apple silicon benchmark |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully enable partial consumption of noncopyable values, fixing a couple of bugs exposed by doing so along the way.
rdar://126715654