6.0: [NoncopyablePartialConsumption] Promote to feature. #73159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove all checks for the feature flag. It's on all the time.
A destroy_value of an on-stack partial apply isn't actually a consuming use, so don't treat it as one.
Previously, the enum representation was fixed to represent the different cases payloads separately with the unchecked_take_enum_data_addr instruction consuming all fields but that whose address is obtained. In a few places, handling for enum deinits was left undone with an assertion that the enum not have one. Here, the deinit bit of the enum is shifted to the end. And the assertions are replaced with handling. Finally, the logic for inserting destroys after switch_enum_addr instructions is fixed.
It's not allowed to replace ued(enum(x)) with x if the enum in question has a deinit.
It relies on complete lifetimes for its analysis. So if there are any instructions to check, complete all lifetimes in the function first.
|
@swift-ci please test |
|
@swift-ci please test macos platform |
kavon
approved these changes
Apr 22, 2024
tbkka
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Enable noncopyable partial consumption by default.
Enabling the feature exposed some bugs that needed to be fixed along the way:
drop_deinits in one place in optimizer.on_stackpartial applies don't consume guaranteed arguments their context captures.Scope: Affects noncopyable code.
Issue: rdar://126715654
Original PR: [NoncopyablePartialConsumption] Promote to feature. #73121
Risk: Medium.
Testing: Updated unit tests.
Reviewer: @jckarter, @kavon