[stdlib] Fixing compilation warnings #7314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<rdar://problem/30320630>
|
@swift-ci Please test |
parkera
reviewed
Feb 8, 2017
| @@ -25,7 +25,7 @@ extension INRequestRideIntent { | |||
| paymentMethod: INPaymentMethod? = nil, | |||
| scheduledPickupTime: INDateComponentsRange? = nil | |||
| ) { | |||
| if #available(iOS 10.3, watchOS 3.2, *) { | |||
| if #available(iOS 10.3, *) { | |||
There was a problem hiding this comment.
Is it correct to drop availability here?
There was a problem hiding this comment.
The whole extension is only available in watchOS 3.2, so this check will always be true. (At least that what the compiler warning said).
|
@parkera I looked at a couple of files in xcorelibs-foundation and they don't have this code. Will compile it locally and fix the warnings. Thanks for pointing it out! |
|
FYI we are stuck with some warnings because the compiler produces warnings about bridging on Darwin in code that is required for Linux. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://problem/30320630