[stdlib] Clean up some more unsafeBitCast warnings #7329
Conversation
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux platform |
|
Ah, beaten to the punch by #7314 |
| return withUnsafePointer(to: &bytes) { | ||
| return NSUUID(uuidBytes: unsafeBitCast($0, to: UnsafePointer<UInt8>.self)) | ||
| return withUnsafeMutablePointer(to: &bytes, as: UInt8.self, capacity: MemoryLayout.size(ofValue: bytes)) { | ||
| return NSUUID(uuidBytes: $0) | ||
| } |
There was a problem hiding this comment.
Nice, I didn't know about that form of withUnsafePointer. That might be a better recommendation for the compiler to emit a warning for when bitcasting from a homogeneous tuple to its element type. Mind filing a bug for that diagnostic improvement?
There was a problem hiding this comment.
Oh, that was one I'd written just for UUID.swift since it has so many of the two operations together (convert to pointer and then cast). It's here—could be a nice addition, but I don't know that it's necessary: https://github.com/apple/swift/pull/7329/files/cf260a26173985f867fb33cf52c808ec481aad44#diff-9e8b701cacc2a5ba71da8979a386a127R16
There was a problem hiding this comment.
I missed that. It does seem like a generally useful variant.
|
Oops. Sorry =) |
This cleans up (I think) the remainder of the warnings that fell out of the improved
unsafeBitcast. 🤞