Skip to content

[LifetimeCompletion] Enable. #73275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 25, 2024
Merged

[LifetimeCompletion] Enable. #73275

merged 3 commits into from
Jul 25, 2024

Conversation

nate-chandler
Copy link
Contributor

@nate-chandler nate-chandler commented Apr 26, 2024 •
edited
Loading

Complete OSSA lifetimes during SILGen cleanup.

@nate-chandler nate-chandler force-pushed the lifetime-completion/enable branch 2 times, most recently from 6ccc74a to 59e78b3 Compare May 14, 2024 19:37
@nate-chandler nate-chandler force-pushed the lifetime-completion/enable branch 5 times, most recently from 90a3c01 to 4995017 Compare May 25, 2024 16:44
@nate-chandler nate-chandler force-pushed the lifetime-completion/enable branch 2 times, most recently from 3ef85bd to 3392013 Compare May 30, 2024 22:08
@nate-chandler nate-chandler force-pushed the lifetime-completion/enable branch from 3392013 to d24c764 Compare June 6, 2024 23:20
@nate-chandler nate-chandler force-pushed the lifetime-completion/enable branch from 876e847 to af28401 Compare June 24, 2024 20:05
@nate-chandler nate-chandler force-pushed the lifetime-completion/enable branch 2 times, most recently from f9a9073 to cb65f75 Compare July 3, 2024 03:36
@nate-chandler nate-chandler force-pushed the lifetime-completion/enable branch 4 times, most recently from 7c4fee8 to 1f2c575 Compare July 25, 2024 00:54
@nate-chandler
[OwnedLifetimeCan] Persist [dead_end].
c726366 
When creating `destroy_value`s, create them with the `dead_end` flag if
all subsequent destroys (those from which it is notionally being
hoisted) have the flag.
@nate-chandler
[ClosureLifetimeFixup] Flag dead-end destroys.
92e5dc8
@nate-chandler
[LifetimeCompletion] Enable.
bff6c74 
Complete all lifetimes during SILGenCleanup.
@nate-chandler nate-chandler force-pushed the lifetime-completion/enable branch from 1f2c575 to bff6c74 Compare July 25, 2024 00:56
@nate-chandler
Copy link
Contributor Author

@swift-ci please apple silicon benchmark

@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler
Copy link
Contributor Author

@swift-ci please test source compatibility

@nate-chandler
Copy link
Contributor Author 

### Performance (arm64): -O

**Regression**                   | **OLD**  | **NEW**  | **DELTA** | **RATIO**
:---                             | ---:     | ---:     | ---:   | ---:
ArrayOfPOD                       | 149.5    | 163.1    | +9.1%  | **0.92x (?)**
ArrayOfGenericPOD2               | 147.923  | 160.933  | +8.8%  | **0.92x (?)**
  | | | |
**Improvement**                  | **OLD**  | **NEW**  | **DELTA** | **RATIO**
ObserverUnappliedMethod          | 293.182  | 258.431  | -11.9% | **1.13x (?)**
DataAppendDataMediumToLarge      | 5475.862 | 5024.658 | -8.2%  | **1.09x (?)**
Data.init.Sequence.809B.Count.RE | 12.647   | 11.783   | -6.8%  | **1.07x (?)**

### Code size: -O


### Performance (arm64): -Osize

**Regression**                         | **OLD** | **NEW** | **DELTA** | **RATIO**
:---                                   | ---:    | ---:    | ---:   | ---:
RawBufferCopyBytes                     | 9.589   | 10.771  | +12.3% | **0.89x (?)**
Array.removeAll.keepingCapacity.Object | 2.318   | 2.569   | +10.8% | **0.90x (?)**
  | | | |
**Improvement**                        | **OLD** | **NEW** | **DELTA** | **RATIO**
StringWithCString2                     | 0.002   | 0.001   | -33.3% | **1.50x**
ObserverUnappliedMethod                | 295.652 | 273.636 | -7.4%  | **1.08x (?)**

### Code size: -Osize


### Performance (arm64): -Onone

**Regression**        | **OLD** | **NEW** | **DELTA** | **RATIO**
:---                  | ---:    | ---:    | ---:   | ---:
SortArrayInClass      | 60624.0 | 72023.0 | +18.8% | **0.84x (?)**
  | | | |
**Improvement**       | **OLD** | **NEW** | **DELTA** | **RATIO**
DataMutateBytesMedium | 866.531 | 807.692 | -6.8%  | **1.07x (?)**

### Code size: -swiftlibs

@nate-chandler nate-chandler requested a review from atrick July 25, 2024 01:44
@nate-chandler nate-chandler marked this pull request as ready for review July 25, 2024 03:41
@nate-chandler nate-chandler requested a review from xedin as a code owner July 25, 2024 03:41
@nate-chandler
Copy link
Contributor Author

@swift-ci please test source compatibility release

atrick
atrick approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@nate-chandler nate-chandler merged commit 840198e into swiftlang:main Jul 25, 2024
7 of 8 checks passed
@nate-chandler nate-chandler deleted the lifetime-completion/enable branch July 25, 2024 19:29
nate-chandler added a commit to nate-chandler/swift that referenced this pull request Jul 26, 2024
@nate-chandler
Revert "Merge pull request swiftlang#73275 from nate-chandler/lifetim…
a7c6538 
…e-completion/enable"

This reverts commit 840198e, reversing
changes made to b74303c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atrick atrick atrick approved these changes

@eeckstein eeckstein Awaiting requested review from eeckstein eeckstein is a code owner

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nate-chandler @atrick