[cmake] Only check HostCompatibilityLibs for bootstrapping builds #73383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Locally I build debug builds without the standard library, using a copy of the stdlib in my release build. This hit a CMake error here since the `HostCompatibilityLibs` target isn't defined. Update to only access it when doing a bootstrapping build.
|
@edymtt Not sure if this is the best fix, let me know if you have any better ideas |
|
@swift-ci please test |
edymtt
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locally I build debug builds without the standard library, using a copy of the stdlib in my release build. This hit a CMake error here since the
HostCompatibilityLibstarget isn't defined. Update to only access it when doing a bootstrapping build.