[6.0 🍒][CMake] Establish a dependency from standard library variants onto 'libSwiftScan' #77704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
artemcm
force-pushed
the
60_MoveLibSwiftScanOutOfTools
branch
2 times, most recently
from
10a32d5 to
9d328e0
Compare
|
@swift-ci test |
|
@swift-ci test macOS platform |
1 similar comment
|
@swift-ci test macOS platform |
… when building the Standard Library"
'tools' should be reserved for executable tools.
Locally I build debug builds without the standard library, using a copy of the stdlib in my release build. This hit a CMake error here since the `HostCompatibilityLibs` target isn't defined. Update to only access it when doing a bootstrapping build.
This was already the intention before, but it didn't work because cmake's `option` only works for boolean variables. Using `set` instead of `option` fixes that. This change also enables SwiftCompilerSources in lldb on Windows. swiftlang#73322
artemcm
force-pushed
the
60_MoveLibSwiftScanOutOfTools
branch
from
9d328e0 to
0735d49
Compare
|
Testing adding db50797 to this change. |
|
@swift-ci test |
nkcsgexi
approved these changes
Dec 2, 2024
DougGregor
reviewed
Dec 2, 2024
| @@ -362,7 +361,7 @@ How to build the swift compiler modules. Possible values are | |||
| `SWIFT_NATIVE_SWIFT_TOOLS_PATH` (non-Darwin only) | |||
| CROSSCOMPILE-WITH-HOSTLIBS: build with a bootstrapping-with-hostlibs compiled | |||
| compiler, provided in `SWIFT_NATIVE_SWIFT_TOOLS_PATH` | |||
| ]=] OFF) | |||
| ]=]) | |||
There was a problem hiding this comment.
I do not think we should be removing OFF here. I'm actually trying to get it working again in #77815 :)
|
@artemcm Please add the cherry-pick template here. The build changes here feel a bit invasive, and it's not clear how to weigh the benefit of taking this in the 6.0 branch vs. the risks associated with the build changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #77606 and #77621 and #73383