Skip to content

NCGenerics: it's not experimental #73501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2024

Conversation

kavon
Copy link
Member

@kavon kavon commented May 7, 2024

This PR promotes the experimental feature to a full language feature. Also fixes a bug where you could use the feature without the right flags in the swiftinterface file for feature-guarded declarations (rdar://127701059)

@kavon
Copy link
Member Author

kavon commented May 7, 2024

@swift-ci test

@kavon kavon enabled auto-merge May 7, 2024 23:27
@kavon kavon disabled auto-merge May 7, 2024 23:45
kavon added 2 commits May 8, 2024 10:49
It will always evaluate to true now; it's not experimental. This change
effectively reverts the following:
 - 6140ba1
 - 78eee32
@kavon kavon force-pushed the ncgeneric-not-experimental branch from f8bd943 to b04be89 Compare May 8, 2024 17:50
@kavon
Copy link
Member Author

kavon commented May 8, 2024

@swift-ci test

@kavon kavon enabled auto-merge May 8, 2024 17:50
Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The C++ interop bits LGTM!

@kavon kavon merged commit 21b303f into swiftlang:main May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants