NCGenerics: add test for feature flag & force-enable all #73522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
|
@swift-ci smoke test Linux |
|
@swift-ci smoke test windows |
|
@swift-ci smoke test macOS |
kavon
force-pushed
the
ncgeneric-coverage-rdar127701059
branch
from
0003267 to
7799c4a
Compare
kavon
changed the title
|
@swift-ci smoke test |
Regardless of whether someone made it non-experimental, or deleted all the checks in the compiler, really, truly, make sure the bit is set to indicate we have the darn feature.
Ensure that when using noncopyable generics when building a module, the compiler can re-ingest it and will pick the part guarded by $NoncopyableGenerics. verifies the concern in rdar://127701059
This reverts commit b04be89.
kavon
force-pushed
the
ncgeneric-coverage-rdar127701059
branch
from
7799c4a to
be46fe4
Compare
|
@swift-ci smoke test |
We haven't yet solved the underlying issue in rdar://128013193 and the
workaround to make it conditionally use the better importing strategy of
Unsafe{Mutable}Pointer no longer will apply, since NoncopyableGenerics
is here.
kavon
force-pushed
the
ncgeneric-coverage-rdar127701059
branch
from
be46fe4 to
89ff3fe
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that when using noncopyable generics when building a module, the compiler can re-ingest it and will pick the part guarded by $NoncopyableGenerics.
verifies the concern in rdar://127701059