[6.0🍒] NCGenerics: add test for feature flag & force-enable all #73594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regardless of whether someone made it non-experimental, or deleted all the checks in the compiler, really, truly, make sure the bit is set to indicate we have the darn feature. (cherry picked from commit 0d2fdad)
Ensure that when using noncopyable generics when building a module, the compiler can re-ingest it and will pick the part guarded by $NoncopyableGenerics. verifies the concern in rdar://127701059 (cherry picked from commit 7799c4a)
|
@swift-ci test |
tbkka
approved these changes
May 13, 2024
|
@swift-ci test |
kavon
force-pushed
the
6.0-ncgeneric-coverage-rdar127701059
branch
from
7c6dc94 to
99d417b
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Ensures that feature-guards in interfaces always evaluate to true for NoncopyableGenerics, BorrowingSwitch, and MoveOnlyPartialConsumption. This is sort of a part (2) of #73514 that can be merged independently and I think both should be included to call this issue resolved.
Scope: Important for people who start using the feature without the flag in their build configuration, so they actually emit correct swiftinterface files.
Issue: rdar://127701059
Original PR: #73522
Risk: Low.
Testing: test is included
Reviewer: