Skip to content

Fix a linking issue introduced by recent SILModule changes. #7401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2017

Conversation

swiftix
Copy link
Contributor

@swiftix swiftix commented Feb 11, 2017

Only convert external public functions into declarations, because they are available elsewhere.

Hopefully this small change can fix the linking issues discovered by CI bots. For some reason, swift-ci was not able to catch any of these issues when it was testing.

@swiftix
Copy link
Contributor Author

swiftix commented Feb 11, 2017

@swift-ci please smoke test

Only convert external public functions into declarations, because they are available elsewhere.
@swiftix swiftix force-pushed the wip-generics-inlining-flag-4 branch from c051e1b to e744739 Compare February 11, 2017 08:21
@swiftix
Copy link
Contributor Author

swiftix commented Feb 11, 2017

@swift-ci please smoke test

1 similar comment
@swiftix
Copy link
Contributor Author

swiftix commented Feb 11, 2017

@swift-ci please smoke test

@swiftix swiftix merged commit a380855 into swiftlang:master Feb 11, 2017
jrose-apple added a commit to jrose-apple/swift that referenced this pull request Feb 13, 2017
…nlining-flag-4"

This reverts commit a380855, reversing
changes made to 6633214.

We're seeing a handful of issues from turning on inlining of generics,
so I'm reverting to unblock the bots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant