Revert generics inlining for now #7428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test and merge |
|
FYI it would have been better to just disable the flag. All this revering and re-applying makes 'git blame' less useful. |
|
@slavapestov Very good point! I totally forgot about this possibility :-( |
|
@slavapestov Any thoughts on rdar://30490994? What should we do in case of opened existentials? |
|
@swiftix I'll take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #6092 and #7401 for now. We're seeing a handful of issues from turning on inlining of generics, including
Assertion failed: (DebugLocListIndex == ~0U && !MInsn && "not an MMI entry")(rdar://problem/30479945) andAssertion failed: (!type->hasArchetype() && "Forgot to map typeref out of context")(rdar://problem/30490994), so I'm reverting to unblock the bots.