[Caching] Teach libSwiftScan to replay all diagnostics kinds #74128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachemeifyoucan
requested review from
akyrtzi,
DougGregor,
benlangmuir,
artemcm and
jansvoboda11
|
@swift-ci please smoke test |
cachemeifyoucan
force-pushed
the
eng/PR-129015959
branch
from
63d58d8 to
fd0f519
Compare
|
@swift-ci please smoke test |
Extract the logics for emitting diagnostics, especially the parseable output message, from FrontendTools so it is easier to reason.
Add support for serialized diagnostics, parseable output, and other kinds of output from diagnostics engine to the libSwiftScan replayCompilation API. rdar://129015959
cachemeifyoucan
force-pushed
the
eng/PR-129015959
branch
from
fd0f519 to
1912d0b
Compare
|
@swift-ci please smoke test |
|
ping for review. |
|
@swift-ci please smoke test macOS platform |
|
ping |
|
Another ping |
artemcm
approved these changes
Jun 26, 2024
| // StaticLinkJob, DynamicLinkJob | ||
| } | ||
|
|
||
| // TODO: Apply elsewhere in the compiler |
There was a problem hiding this comment.
This is directly transported from original code. Do I own the TODO now that git blame will trace to me?
There was a problem hiding this comment.
Yeah, I think that's the law. 🤷🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two commits:
This allows supporting in-process replay from build system for all the diagnostics kind without diverging with the handling in swift-frontend.