[6.0][Caching] Teach libSwiftScan to replay all diagnostics kinds #74819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract the logics for emitting diagnostics, especially the parseable output message, from FrontendTools so it is easier to reason. (cherry picked from commit e239ee8)
Add support for serialized diagnostics, parseable output, and other kinds of output from diagnostics engine to the libSwiftScan replayCompilation API. rdar://129015959 (cherry picked from commit 1912d0b)
|
@swift-ci please test |
nkcsgexi
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Teach swift caching replay API to replay all diagnostics output kind, including parseable output and serialized diagnostics.
Scope: This allows build system to replay all diagnostics from scanner API in process.
Issue: rdar://129015959
Original PR: #74128
Reviewer: @artemcm
Risk: Low. Swift caching only change.
Test: Unit Tests