Add #include "swift/Basic/Assertions.h" to a lot of source files
#74184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although I don't plan to bring over new assertions wholesale into the current qualification branch, it's entirely possible that various minor changes in main will use the new assertions; having this basic support in the release branch will simplify that. (This is why I'm adding the includes as a separate pass from rewriting the individual assertions)
tbkka
requested review from
QuietMisdreavus,
artemcm,
AnthonyLatsis,
hborla,
slavapestov,
xedin,
ktoso,
tshortli,
kavon,
adrian-prantl,
ahoppen,
bnbarham,
hamishknight,
rintaro,
zoecarver,
hyp,
egorzhdan,
CodaFi,
DougGregor,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci Please test |
beccadax
approved these changes
Jun 6, 2024
|
@swift-ci Please smoke test Linux platform |
|
@swift-ci Please smoke test |
tbkka
removed request for
AnthonyLatsis,
hborla,
slavapestov,
xedin,
ktoso,
tshortli,
kavon,
adrian-prantl,
bnbarham,
hamishknight,
rintaro,
zoecarver,
hyp,
egorzhdan,
CodaFi,
DougGregor and
ian-twilightcoder
nico
added a commit
to nico/swift
that referenced
this pull request
Aug 5, 2024
They are not used. Demangling uses `assert()` from <cassert>, and macros from lib/Demangling/DemanglerAssert.h. Reverts the lib/Demangling changes from swiftlang#74184. No behavior change.
nico
added a commit
to nico/swift
that referenced
this pull request
Aug 5, 2024
They are not used. Demangling uses `assert()` from <cassert>, and macros from lib/Demangling/DemanglerAssert.h. Reverts the lib/Demangling changes from swiftlang#74184. No behavior change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the new assertion macros from #73675 available throughout the project.
This does not change any current behavior. The new assertion macros have different names and will have no impact until folks start using
ASSERT,CONDITIONAL_ASSERT, andDEBUG_ASSERTin code instead of the oldassertmacro.Although I don't plan to bring over new assertions wholesale into the current release branch, it's entirely possible that various changes in main will use the new assertions; having this basic support in the release branch will simplify that. (This is why I'm adding the includes as a separate pass from rewriting the individual assertions, to make it possible to implement the support in the release branch without copying any actual assertion changes.)