[Demangling] Remove includes of swift/Basic/Assertions.h #75690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are not used. Demangling uses `assert()` from <cassert>, and macros from lib/Demangling/DemanglerAssert.h. Reverts the lib/Demangling changes from swiftlang#74184. No behavior change.
nico
force-pushed
the
demangle-assertion
branch
from
e61967c to
9d5359d
Compare
nico
changed the title
|
@compnerd Last one for now? :) |
|
CC @tbkka |
|
@swift-ci please test |
|
Eventually, we want to make the new assertions usable by runtime content, but there's some additional work before that's feasible. In the meantime, I have no objections to removing these includes. |
tbkka
approved these changes
Aug 6, 2024
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are not used. Demangling uses
assert()from , and macros from lib/Demangling/DemanglerAssert.h.Reverts the lib/Demangling changes from #74184.
No behavior change.
If someone could toggle CI, that'd be appreciated :)