[cxx-interop] Fix extra indirection when exporting CFData arguments #74330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xazax-hun
requested review from
zoecarver,
hyp,
egorzhdan,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci please smoke test |
Xazax-hun
changed the title
egorzhdan
reviewed
Jun 12, 2024
|
@swift-ci please smoke test |
egorzhdan
approved these changes
Jun 12, 2024
Xazax-hun
force-pushed
the
gaborh/core-foundation-types
branch
from
f6eb56d to
7c29970
Compare
|
Looks like I had to make the test |
|
@swift-ci please smoke test |
egorzhdan
reviewed
Jun 12, 2024
test/Interop/SwiftToCxx/stdlib/core-foundation-types-in-cxx.swift
Outdated
Show resolved
Hide resolved
…eturn values The clang nodes associated with Swift's Core Foundation types can already be represented by a pointer. The interop code does not need to add an extra layer of indirection in those cases. rdar://119840281
Xazax-hun
force-pushed
the
gaborh/core-foundation-types
branch
from
7c29970 to
ae1f804
Compare
|
@swift-ci please smoke test |
Xazax-hun
added a commit
that referenced
this pull request
Jun 24, 2024
[cxx-interop] Fix extra indirection when exporting CFData arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clang nodes associated with Swift's Core Foundation types can already be represented by a pointer. The interop code does not need to add an extra layer of indirection in those cases.
rdar://119840281