🍒[cxx-interop] Fix extra indirection when exporting CFData parameters #74663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[cxx-interop] Fix extra indirection when exporting CFData arguments
|
@swift-ci please test |
Xazax-hun
changed the title
rjmccall
approved these changes
Jun 24, 2024
DougGregor
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
The clang nodes associated with Swift's Core Foundation types are already represented by a pointer. The interop code does not need to add an extra layer of indirection in those cases.
Scope: C++ Interop
Risk: Very targeted fix for a scenario that was broken before, the code change only affects that scenario.
Testing: Added a regression test.
Issue: rdar://119840281
Reviewer: @egorzhdan
Original PR: #74330