embedded: add swift_dynamicCastClass runtime function #74332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
|
Does this mean KeyPath could one day be supported in Embedded mode? |
Yes, but unrelated to this change. The standard keypath runtime is probably too heavy for embedded swift. But we could support e.g. keypaths to stored properties only, which means that in embedded swift a keypath is just an integer offset. |
kubamracek
approved these changes
Jun 12, 2024
|
@swift-ci please test |
kubamracek
reviewed
Jun 12, 2024
| @_cdecl("swift_dynamicCastClass") | ||
| public func swift_dynamicCastClass(object: UnsafeRawPointer, targetMetadata: UnsafeRawPointer) -> UnsafeRawPointer? { | ||
| let sourceObj = object.assumingMemoryBound(to: HeapObject.self) | ||
| var type = sourceObj.pointee.metadata.assumingMemoryBound(to: ClassMetadata.self) |
There was a problem hiding this comment.
I think this might need to be a call to _swift_embedded_get_heap_object_metadata_pointer instead, to respect ptrauth correctly?
To enable dynamic class casts rdar://129672994
eeckstein
force-pushed
the
swift_dynamiccastclass
branch
from
0f6d8df to
13ecb51
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable dynamic class casts
rdar://129672994