Skip to content

[6.0] embedded: add swift_dynamicCastClass runtime function #74380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2024
Merged

[6.0] embedded: add swift_dynamicCastClass runtime function #74380

merged 1 commit into from
Jun 13, 2024

Conversation

eeckstein
Copy link
Contributor

  • Explanation: Fixes a linker error when doing a dynamic class down cast. The swift_dynamicCastClass runtime function was missing.
  • Scope: Only affects embedded swift.
  • Risk: very low. There is no change in existing code. Just the new runtime function is added.
  • Testing: Tested by a test case
  • Issue: rdar://129672994
  • Reviewer: @kubamracek
  • Main branch PR: embedded: add swift_dynamicCastClass runtime function #74332

@eeckstein
embedded: add swift_dynamicCastClass runtime function
b21dce7 
To enable dynamic class casts

rdar://129672994
@eeckstein eeckstein requested a review from a team as a code owner June 13, 2024 06:10
@eeckstein
Copy link
Contributor Author

@swift-ci test

@eeckstein eeckstein requested a review from kubamracek June 13, 2024 06:11
@eeckstein eeckstein changed the title embedded: add swift_dynamicCastClass runtime function [6.0] embedded: add swift_dynamicCastClass runtime function Jun 13, 2024
@eeckstein eeckstein merged commit bd91438 into swiftlang:release/6.0 Jun 13, 2024
5 checks passed
@eeckstein eeckstein deleted the swift_dynamiccastclass-6.0 branch June 13, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbkka tbkka tbkka approved these changes

@kubamracek kubamracek Awaiting requested review from kubamracek

Assignees
No one assigned
Labels
swift 6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eeckstein @tbkka